Skip to content

Custom sort order support, remove duplicate keymap files, update menu #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 6, 2013

Conversation

i-akhmadullin
Copy link
Member

No description provided.

@i-akhmadullin
Copy link
Member Author

@miripiruni just added support for sublime 2 and 3 when you have time please review this changes :)

{ "caption": "-" },
{
"command": "open_file",
"args": {
"file": "${packages}/CSScomb/Default (OSX).sublime-keymap",
"platform": "OSX"
"file": "${packages}/CSScomb/CSScomb - Order.sublime-settings"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the path is wrong. I can't see "CSScomb - Order.sublime-settings"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check one more time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@miripiruni
Copy link
Contributor

@i-akhmadullin, а как работает кастомная сортировка? Я зашел в Preferences → Package Settings → CSScomb → Sort order - User, создал там JSON с настройками, но они не приминились. Зашел в Preferences → Package Settings → CSScomb → Sort order - Default и изменил там и тоже ничего не применяется...

@miripiruni
Copy link
Contributor

В консоли вижу вот такое

Traceback (most recent call last):
  File "/Applications/Sublime Text 3.app/Contents/MacOS/sublime_plugin.py", line 418, in run_
    return self.run(edit)
  File "/Users/miripiruni/Library/Application Support/Sublime Text 3/Packages/CSScomb/CSScomb.py", line 55, in run
    myprocess = subprocess.Popen(['php', csscomb_path, selbody, self.sortorder], shell=False, stdout=subprocess.PIPE, startupinfo=self.startupinfo)
  File "X/subprocess.py", line 818, in __init__
  File "X/subprocess.py", line 1363, in _execute_child
TypeError: Can't convert 'list' object to str implicitly

@i-akhmadullin
Copy link
Member Author

В процессе переписывания потерял одну строчку )
Теперь должно работать

miripiruni added a commit that referenced this pull request Mar 6, 2013
Custom sort order support, remove duplicate keymap files, update menu
@miripiruni miripiruni merged commit 11718f3 into csscomb:master Mar 6, 2013
@miripiruni
Copy link
Contributor

Илья, спасибо большое!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants