bridge: be tolerant to missing references #81
Conversation
| @@ -164,7 +164,7 @@ protected void initializeAnimation() { | |||
| t = element.getParentNode(); | |||
| } else { | |||
| t = ctx.getReferencedElement(element, uri); | |||
| if (t.getOwnerDocument() != element.getOwnerDocument()) { | |||
| if (t == null || t.getOwnerDocument() != element.getOwnerDocument()) { | |||
There was a problem hiding this comment.
Won't this still throw an exception when the referenced element cannot be found?
There was a problem hiding this comment.
Won't this still throw an exception when the referenced element cannot be found?
Yes, and it's the only thing that can be done with the current API, unless you want to silently ignore the problem.
I could change the API so the error can be processed, but that should be a different commit.
| @@ -265,6 +266,15 @@ public static String getChainableAttributeNS(Element element, String namespaceUR | |||
| URIResolver resolver = ctx.createURIResolver(svgDoc, loader); | |||
| e = resolver.getElement(purl.toString(), e); | |||
| refs.add(purl); | |||
| } catch (FileNotFoundException ioEx) { | |||
| BridgeException ex = new BridgeException(ctx, e, ioEx, ERR_URI_IO, | |||
There was a problem hiding this comment.
What do you think about isolating this duplicated code, possibly by delegating to the UserAgent using a static method?
catch(final FileNotFoundException fnfEx) {
final BridgeExceptoin ex = new BridgeException(...);
UserAgent.handle( ex, ctx );
return "";
}Doesn't have to go to the UserAgent, but it would be nice to see the duplication in one spot.
There was a problem hiding this comment.
That could be a non-static method call to ctx but the code would be less readable (one has to look at what that method does) and more bytecode would be generated.
Instead of throwing an exception (and stop processing) on a missing reference, just report the error via the user agent and keep processing. This is what a conformant user agent is supposed to do. There are other circumstances (like other I/O errors) where it would make sense to behave in the same way, but this is deferred to future updates. The `slideshow` and `extension` modules are also affected.
carlosame
force-pushed
the
fe-missing-references
branch
from
0020ede to
ba1fbcd
Compare
Instead of throwing an exception (and stop processing) on a missing reference, just report the error via the user agent and keep processing. This is what a conformant user agent is supposed to do.
There are other circumstances (like other I/O errors) where it would make sense to behave in the same way, but this may break POLA for legacy applications and is deferred to future updates. User feedback is encouraged.
The
slideshowandextensionmodules are also affected by this PR.Fixes #80.