Upgrade loader-utils #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref https://bundlephobia.com/package/generic-names@3.0.0 Hey! I'm on the mission to make vite smaller. This package may benefit from the newest loader-utils version. Also would be good to import interpolateName directly. My local npm 7 migrated lockfile. Tests are slightly changed. I guess due to changes in algorithm.
alexander-akait
approved these changes
Dec 21, 2021
|
I will do major release tomorrow |
|
Thanks |
TrySound
added a commit
to TrySound/vite
that referenced
this pull request
Dec 23, 2021
Found generic-names is a big one because consumes old loader-utils. I upgraded it and imported interpolateName directly to bundle less code in vite. css-modules/generic-names#14 madyankin/postcss-modules#129 https://bundlephobia.com/package/postcss-modules@4.3.0 https://packagephobia.com/result?p=postcss-modules ``` du -sk dist/node ``` before 12268 after 11968
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref https://bundlephobia.com/package/generic-names@3.0.0
Hey! I'm on the mission to make vite smaller.
This package may benefit from the newest loader-utils version.
Also would be good to import interpolateName directly.
My local npm 7 migrated lockfile.
Tests are slightly changed. I guess due to changes in algorithm.