Skip to content

added preliminary support for new gtest macro GTEST_SKIP() - #262

Merged
csoltenborn merged 3 commits into
masterfrom
#260_GTEST_SKIP
Feb 5, 2019
Merged

added preliminary support for new gtest macro GTEST_SKIP()#262
csoltenborn merged 3 commits into
masterfrom
#260_GTEST_SKIP

Conversation

@csoltenborn

Copy link
Copy Markdown
Owner

Added support for GTEST_SKIP() macro (not yet released) - this takes case of #260

@sixten-hilborn: Would you mind to give it a try? You can download the according build artifacts from here...

As a side note: I have not tested this on the actual adapter, but merely adjusted the output parsers and provided according unit tests. However, the skipped tests have been marked as failures before the patch, but not as test crashes. Is the skipped test indeed marked as "probably CRASHED" for the minimal example you provided, or is there anything special about the test which made you report the issue in the first place?

@csoltenborn csoltenborn self-assigned this Feb 2, 2019
@csoltenborn csoltenborn added this to the 0.14.3 milestone Feb 2, 2019
@codecov

codecov Bot commented Feb 2, 2019

Copy link
Copy Markdown

Codecov Report

Merging #262 into master will increase coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   73.52%   73.63%   +0.11%     
==========================================
  Files          95       95              
  Lines        3565     3580      +15     
  Branches      516      519       +3     
==========================================
+ Hits         2621     2636      +15     
  Misses        765      765              
  Partials      179      179
Flag Coverage Δ
#Integration 52.7% <17.64%> (-0.2%) ⬇️
#Unit 60.22% <100%> (+0.16%) ⬆️
Impacted Files Coverage Δ
...Results/StreamingStandardOutputTestResultParser.cs 92.85% <100%> (+0.38%) ⬆️
...Core/TestResults/StandardOutputTestResultParser.cs 96.22% <100%> (+0.39%) ⬆️

@codecov

codecov Bot commented Feb 2, 2019

Copy link
Copy Markdown

Codecov Report

Merging #262 into master will increase coverage by 1.4%.
The diff coverage is 70.83%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #262     +/-   ##
=========================================
+ Coverage   73.52%   74.92%   +1.4%     
=========================================
  Files          95       95             
  Lines        3565     3605     +40     
  Branches      516      524      +8     
=========================================
+ Hits         2621     2701     +80     
+ Misses        765      725     -40     
  Partials      179      179
Flag Coverage Δ
#Integration 55.25% <37.5%> (+2.35%) ⬆️
#Unit 60.11% <64.58%> (+0.05%) ⬆️
Impacted Files Coverage Δ
...Results/StreamingStandardOutputTestResultParser.cs 93.87% <100%> (+1.4%) ⬆️
...leTestAdapter/Core/Runners/SequentialTestRunner.cs 75.89% <100%> (+2.67%) ⬆️
...Core/TestResults/StandardOutputTestResultParser.cs 96.22% <100%> (+0.39%) ⬆️
...gleTestAdapter/Core/Runners/TestResultCollector.cs 88.13% <100%> (+23.72%) ⬆️
...estAdapter/Core/TestResults/XmlTestResultParser.cs 80% <50%> (-12%) ⬇️
...ProcessExecution/DebuggedProcessExecutorFactory.cs 83.33% <0%> (+16.66%) ⬆️
...ocessExecution/FrameworkDebuggedProcessExecutor.cs 68% <0%> (+68%) ⬆️
... and 1 more

@sixten-hilborn

Copy link
Copy Markdown

That was fast! :)
I'll probably not be able to test this until Monday. I'm not sure if this case was reported as crashed, but I definitely had another test reported as crashed. I'll double-check that!

@csoltenborn

Copy link
Copy Markdown
Owner Author

If you give it a try, please use this build...

@sixten-hilborn

Copy link
Copy Markdown

Yep, now they're correctly reported as Skipped !

@csoltenborn
csoltenborn merged commit bee333f into master Feb 5, 2019
@csoltenborn
csoltenborn deleted the #260_GTEST_SKIP branch February 5, 2019 17:55
@csoltenborn

Copy link
Copy Markdown
Owner Author

Great, thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants