added preliminary support for new gtest macro GTEST_SKIP() - #262
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
+ Coverage 73.52% 73.63% +0.11%
==========================================
Files 95 95
Lines 3565 3580 +15
Branches 516 519 +3
==========================================
+ Hits 2621 2636 +15
Misses 765 765
Partials 179 179
|
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
=========================================
+ Coverage 73.52% 74.92% +1.4%
=========================================
Files 95 95
Lines 3565 3605 +40
Branches 516 524 +8
=========================================
+ Hits 2621 2701 +80
+ Misses 765 725 -40
Partials 179 179
|
|
That was fast! :) |
Owner
Author
|
If you give it a try, please use this build... |
|
Yep, now they're correctly reported as Skipped ! |
Owner
Author
|
Great, thanks for testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for GTEST_SKIP() macro (not yet released) - this takes case of #260
@sixten-hilborn: Would you mind to give it a try? You can download the according build artifacts from here...
As a side note: I have not tested this on the actual adapter, but merely adjusted the output parsers and provided according unit tests. However, the skipped tests have been marked as failures before the patch, but not as test crashes. Is the skipped test indeed marked as "probably CRASHED" for the minimal example you provided, or is there anything special about the test which made you report the issue in the first place?