Skip to content

Page crashing when a section with no location is created - fixed #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Page crashing when a section with no location is created - fixed #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9bf9b9e
No location sections are fixed
ddenizdemirtas Oct 31, 2023
a61289a
pre-commit error fixed
ddenizdemirtas Nov 14, 2023
9ee33de
pre-commit error fix2
ddenizdemirtas Nov 14, 2023
d6a2a1d
pre-commit error fix2
ddenizdemirtas Nov 14, 2023
dd5e22b
a
ericyche Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions csm_web/frontend/src/components/course/CreateSectionModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,10 @@ export const CreateSectionModal = ({ courseId, closeModal, reloadSections }: Cre
}
};

/**
* Handle form submission.
*/
const hasEmptyLocation = () => {
return spacetimes.some(spacetime => !spacetime.location?.trim());
};

const handleSubmit = (event: React.MouseEvent<HTMLButtonElement>): void => {
event.preventDefault();
const data = {
Expand Down Expand Up @@ -219,7 +220,7 @@ export const CreateSectionModal = ({ courseId, closeModal, reloadSections }: Cre
<button className="secondary-btn" id="add-occurence-btn" onClick={appendSpacetime}>
Add another occurence
</button>
<button className="primary-btn" onClick={handleSubmit}>
<button className="primary-btn" onClick={handleSubmit} disabled={hasEmptyLocation()}>
Submit
</button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "csm_web",
"version": "1.0.0",
"description": "",
"description": "This repository contains webapps that help support the infrastructure of CSM. Currently, it only holds Scheduler (our section signup and attendance system), but more are on the way.",
"main": "index.tsx",
"scripts": {
"dev": "webpack --mode development",
Expand Down