Remove hardcoded URL that breaks API connectivity#101
Open
davidastephens wants to merge 1 commit intocsingley:masterfrom
Open
Remove hardcoded URL that breaks API connectivity#101davidastephens wants to merge 1 commit intocsingley:masterfrom
davidastephens wants to merge 1 commit intocsingley:masterfrom
Conversation
Commit 0a4989c introduced a hardcoded URL override in request_statement() that breaks API connectivity for many users: ### AKE FIX url = 'https://ndcdyn.interactivebrokers.com/portal.flexweb/api/v1/flexQuery' This line forces all requests to use a non-standard API endpoint, causing timeout errors like 'Request Timeout, re-sending...' for users relying on the standard IB FlexQuery API endpoints. The request_statement() function already has proper URL handling via the REQUEST_URL constant and optional url parameter. This hardcoded override bypasses that logic and breaks existing functionality. Impact: - Users experience API timeouts and connection failures - The url parameter to request_statement() is completely ignored - Applications using this library cannot connect to IB API Solution: Remove the hardcoded URL override and restore the original URL selection logic: url = url or REQUEST_URL This allows the function to work with both the default REQUEST_URL and any custom URLs passed via the url parameter. Fixes connectivity issues introduced in commit 0a4989c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Commit 0a4989c introduced a hardcoded URL override in
request_statement()that breaks API connectivity:This hardcoded URL causes timeout errors for users:
Impact
urlparameter is completely ignoredRoot Cause
The hardcoded URL
https://ndcdyn.interactivebrokers.com/portal.flexweb/api/v1/flexQueryappears to be a non-standard endpoint that doesn't work for most users. The standard endpoint is:Solution
Remove the 2-line hardcoded URL override and restore the original logic:
This allows:
REQUEST_URLurlparameterTesting
Changes
This is a critical fix for API connectivity.