Add proto and sidecar code for volumegroup #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
iPraveenParihar,
Madhu-1,
nixpanic,
Rakshith-R and
yati1998
|
Created a separate PR for proto and sidecar code (will remove these commits from #610 ) so that we can merge this and later on take the controller code once ceph code is merged. |
|
@nixpanic @Madhu-1 @Rakshith-R can you please take a look. |
Rakshith-R
reviewed
Aug 28, 2024
Madhu-1
reviewed
Aug 28, 2024
Nikhil-Ladha
force-pushed
the
add-volumegroup-proto
branch
from
6cfaaf5 to
54f64dc
Compare
Madhu-1
previously approved these changes
Aug 29, 2024
nixpanic
reviewed
Aug 29, 2024
nixpanic
reviewed
Aug 29, 2024
Nikhil-Ladha
force-pushed
the
add-volumegroup-proto
branch
from
54f64dc to
ae53c59
Compare
|
Looks good to me. @Madhu-1 do you want to have a final look? |
Madhu-1
approved these changes
Aug 30, 2024
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio rebase |
updated csi-addons spec api to latest version Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
added required proto files and generated grpc library for internal communications of volume groups. Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
added sidecar service and client setup code for volume group feature Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
✅ Branch has been successfully rebased |
Madhu-1
force-pushed
the
add-volumegroup-proto
branch
from
ae53c59 to
ce0d2b7
Compare
lumiere-bot bot
referenced
this pull request
in coolguy1771/home-ops
Sep 19, 2024
… ) (#5423) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [kubernetes-csi-addons](https://redirect.github.com/csi-addons/kubernetes-csi-addons) | minor | `v0.9.1` -> `v0.10.0` | --- ### Release Notes <details> <summary>csi-addons/kubernetes-csi-addons (kubernetes-csi-addons)</summary> ### [`v0.10.0`](https://redirect.github.com/csi-addons/kubernetes-csi-addons/releases/tag/v0.10.0) [Compare Source](https://redirect.github.com/csi-addons/kubernetes-csi-addons/compare/v0.9.1...v0.10.0) #### What's Changed - Add proto and sidecar code for volumegroup by [@​Nikhil-Ladha](https://redirect.github.com/Nikhil-Ladha) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/652](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/652) - vendor: Bump google.golang.org/grpc from 1.65.0 to 1.66.0 in the golang-dependencies group by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/656](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/656) - vendor: Bump sigs.k8s.io/controller-tools from 0.16.1 to 0.16.2 in /tools in the k8s-dependencies group by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/658](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/658) - vendor: Bump the github-dependencies group across 1 directory with 3 updates by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/657](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/657) - replication: add new Validated condition by [@​Rakshith-R](https://redirect.github.com/Rakshith-R) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/664](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/664) - bundle: Update CSV capability to Seamless Upgrades by [@​black-dragon74](https://redirect.github.com/black-dragon74) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/668](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/668) - Refactor PVC controller by [@​black-dragon74](https://redirect.github.com/black-dragon74) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/662](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/662) - bundle: Add missing CRDs to bundle CSV by [@​black-dragon74](https://redirect.github.com/black-dragon74) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/669](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/669) - vendor: bump the k8s-dependencies group with 3 updates by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/673](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/673) #### New Contributors - [@​Nikhil-Ladha](https://redirect.github.com/Nikhil-Ladha) made their first contribution in [https://github.com/csi-addons/kubernetes-csi-addons/pull/652](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/652) **Full Changelog**: csi-addons/kubernetes-csi-addons@v0.9.1...v0.10.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44NS4wIiwidXBkYXRlZEluVmVyIjoiMzguODUuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvZ2l0aHViLXJlbGVhc2UiLCJ0eXBlL21pbm9yIl19--> Co-authored-by: lumiere-bot[bot] <98047013+lumiere-bot[bot]@users.noreply.github.com>
spiceratops
referenced
this pull request
in spiceratops/k8s-gitops
Sep 26, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [kubernetes-csi-addons](https://redirect.github.com/csi-addons/kubernetes-csi-addons) | minor | `v0.9.1` -> `v0.10.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>csi-addons/kubernetes-csi-addons (kubernetes-csi-addons)</summary> ### [`v0.10.0`](https://redirect.github.com/csi-addons/kubernetes-csi-addons/releases/tag/v0.10.0) [Compare Source](https://redirect.github.com/csi-addons/kubernetes-csi-addons/compare/v0.9.1...v0.10.0) #### What's Changed - Add proto and sidecar code for volumegroup by [@​Nikhil-Ladha](https://redirect.github.com/Nikhil-Ladha) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/652](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/652) - vendor: Bump google.golang.org/grpc from 1.65.0 to 1.66.0 in the golang-dependencies group by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/656](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/656) - vendor: Bump sigs.k8s.io/controller-tools from 0.16.1 to 0.16.2 in /tools in the k8s-dependencies group by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/658](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/658) - vendor: Bump the github-dependencies group across 1 directory with 3 updates by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/657](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/657) - replication: add new Validated condition by [@​Rakshith-R](https://redirect.github.com/Rakshith-R) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/664](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/664) - bundle: Update CSV capability to Seamless Upgrades by [@​black-dragon74](https://redirect.github.com/black-dragon74) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/668](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/668) - Refactor PVC controller by [@​black-dragon74](https://redirect.github.com/black-dragon74) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/662](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/662) - bundle: Add missing CRDs to bundle CSV by [@​black-dragon74](https://redirect.github.com/black-dragon74) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/669](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/669) - vendor: bump the k8s-dependencies group with 3 updates by [@​dependabot](https://redirect.github.com/dependabot) in [https://github.com/csi-addons/kubernetes-csi-addons/pull/673](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/673) #### New Contributors - [@​Nikhil-Ladha](https://redirect.github.com/Nikhil-Ladha) made their first contribution in [https://github.com/csi-addons/kubernetes-csi-addons/pull/652](https://redirect.github.com/csi-addons/kubernetes-csi-addons/pull/652) **Full Changelog**: csi-addons/kubernetes-csi-addons@v0.9.1...v0.10.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://redirect.github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44NS4wIiwidXBkYXRlZEluVmVyIjoiMzguODUuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvZ2l0aHViLXJlbGVhc2UiLCJ0eXBlL21pbm9yIl19-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following codes/logic: