-
Notifications
You must be signed in to change notification settings - Fork 3
Web27 Display Filename #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but please fix the frontend_testing pipeline before merging - Error: Uncaught [Error: useLocation() may be used only in the context of a Router component.]
- you probably need to wrap the parent element in the Router component.
I think you can use a parent useState in Dashboard.tsx and pass it to the Renderer and Sidebar so that you can pass the name to the Edit button too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some style changes needed but besides that lgtm! you can merge once you have removed those unused imports
Why the changes are required
Changes