Fix test enivronment determination #342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you mind removing the But otherwise, LGTM! 🚀 😎 🍅 |
Varun-Sethu
approved these changes
Mar 20, 2023
lhjt
approved these changes
Mar 20, 2023
hdphuong
approved these changes
Apr 2, 2023
ShunyaoLiang
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change no longer requires the
-vflag to be present when testing as it simply checks whether the flag has been added as an environment variable during the loading of the testing package, rather than if it has been set.Seems to be the suggested way of checking if we are in a testing environment according to stack overflow.