Skip to content
This repository was archived by the owner on Jan 23, 2022. It is now read-only.

Conversation

@melanieso
Copy link
Contributor

Intalled some basic FE dependencies, mostly for components:

  • material-ui
  • styled-components
  • prop-types
  • lodash

@melanieso melanieso assigned jjccharles and unassigned jjccharles Aug 25, 2019
@melanieso melanieso requested a review from jjccharles August 25, 2019 12:45
Copy link

@nickw444 nickw444 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are using yarn, then a package-lock.json is not necessary as that is used by npm only.

@jjccharles
Copy link
Contributor

Yep as nick said, lets try and stick to using yarn only so the package-lock.json shouldn't be required

Copy link
Contributor

@jjccharles jjccharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update yarn.lock to match new deps if it hasnt been and remove package-lock.json

@melanieso
Copy link
Contributor Author

oop my bad, done i think 💪

@jjccharles jjccharles merged commit 84ed83e into master Aug 27, 2019
@jjccharles jjccharles deleted the ms/initial-fe-dep branch August 27, 2019 00:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants