Skip to content
This repository was archived by the owner on Jan 23, 2022. It is now read-only.

Conversation

@c-sfeng
Copy link
Contributor

@c-sfeng c-sfeng commented Oct 22, 2019

Added draft routes for /degrees and /courses

c-sfeng and others added 2 commits October 22, 2019 23:17
bofeiw
bofeiw previously requested changes Oct 24, 2019
Copy link
Contributor

@bofeiw bofeiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing worth mentioning on line 9 is that the regex of course code should catch all the courses.
For example ACCT1511 would not be caught if specifying A-S because 'T' > 'S'.
To catch all course codes, A-Z would be better.

#18 (comment)

@c-sfeng c-sfeng changed the title Add files via upload Added endpoints for /degrees and /courses in plannify.js Nov 19, 2019
@c-sfeng c-sfeng closed this Nov 19, 2019
@jjccharles jjccharles reopened this Nov 19, 2019
@c-sfeng
Copy link
Contributor Author

c-sfeng commented Nov 19, 2019

Evidence of testing:

courses POST
request:
"majorName": "Software Engin",
"minorName": ""
response:
courses POST res.txt

The response is missing COMP4951, COMP4952, COMP4953, as they are new courses that can't be found on the legacy handbook

degrees GET
request:
no params
response:
degrees GET res.txt

Copy link
Contributor

@jjccharles jjccharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can do fix pr if issues exist that have not been addressesd

@MChhoeu MChhoeu dismissed bofeiw’s stale review October 9, 2020 09:37

Changes have been resolved

@MChhoeu MChhoeu merged commit 6a34482 into master Oct 9, 2020
@MChhoeu MChhoeu deleted the routes branch October 9, 2020 09:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants