-
Notifications
You must be signed in to change notification settings - Fork 1
Added endpoints for /degrees and /courses in plannify.js #17
Conversation
Added draft routes for /degrees and /courses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing worth mentioning on line 9 is that the regex of course code should catch all the courses.
For example ACCT1511 would not be caught if specifying A-S because 'T' > 'S'.
To catch all course codes, A-Z would be better.
|
Evidence of testing: courses POST The response is missing COMP4951, COMP4952, COMP4953, as they are new courses that can't be found on the legacy handbook degrees GET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can do fix pr if issues exist that have not been addressesd
Added draft routes for /degrees and /courses