Skip to content
This repository was archived by the owner on Jan 23, 2022. It is now read-only.

Conversation

@xLilianW
Copy link

No description provided.

@xLilianW xLilianW requested a review from jjccharles October 19, 2019 22:39
Copy link
Contributor

@jjccharles jjccharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a quick go of it, really good work! Would be awesome if we could also make the major fields and minor fields multiple select. Also had a thought that when we have a whole list of degrees, there are a lot of options that a user will have to parse through, will the selected options be at the top of the select bar? If not maybe we need to look into something like chips to deselect and quickly view what selected options are enabled.

@xLilianW xLilianW requested a review from jjccharles October 25, 2019 05:44
@jjccharles jjccharles merged commit aee3b25 into master Oct 28, 2019
@jjccharles jjccharles deleted the degree-input-form branch October 28, 2019 08:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants