Skip to content

Backend draft #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Nov 5, 2019
Merged

Backend draft #24

merged 44 commits into from
Nov 5, 2019

Conversation

munjoonteo
Copy link
Contributor

Changes

  • Added routes for all major functions except login

Change reason

  • Start of backend

Closes

  • Create an API to access the mongo database

Checklist

  • PR is named appropriately (describe what it does/changes/fixes)
  • Changes are "atomic" (related to the same thing) otherwise consider splitting your PR into two changes
  • You have linked the issues this PR closes by using Close #issue_number
  • You have assigned this PR to yourself (or as appropriate)
  • You have assigned reviewers to the PR
  • You have labelled this PR appropriately
  • You have set the project and milestone
  • You have rebased this PR against the remote base branch using git rebase -i origin/dev (other relevant base branch). Read the contributing guide if you're unsure.

@munjoonteo munjoonteo requested a review from gawdn October 31, 2019 00:42
@munjoonteo munjoonteo self-assigned this Oct 31, 2019
@munjoonteo munjoonteo changed the base branch from master to dev October 31, 2019 00:43
Copy link
Contributor

@gawdn gawdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work - read the comments for a few things to fix up :)

@gawdn gawdn self-requested a review November 4, 2019 12:15
gawdn
gawdn previously approved these changes Nov 4, 2019
Copy link
Contributor

@gawdn gawdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 Merge for now to move this along - but note you have some issues with LDAP also some of your DB commands aren't generating the correct items for the DB (e.g. newCat)

@munjoonteo munjoonteo merged commit 0cd6b7b into dev Nov 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat/API branch November 5, 2019 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants