Skip to content

[CW2-53] Subcom display selection #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 18, 2024
Merged

[CW2-53] Subcom display selection #36

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5619dca
mvp - subcom display selection
PenTest-duck Oct 16, 2024
9154ab7
highlight selected portfolio
PenTest-duck Oct 16, 2024
5c5423d
fix lint
PenTest-duck Oct 16, 2024
a60d908
remove pfps, add execs, fix scrollbar
derekxu04 Oct 18, 2024
550bcba
change colours
derekxu04 Oct 18, 2024
7808dee
Minor grammatical edits
Domin0de Oct 18, 2024
9c4ddcb
Remove unused asset
Domin0de Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
  • Loading branch information
@PenTest-duck
PenTest-duck committed Oct 16, 2024
commit 5c5423d706326b856384dd5bddc1ba4d830068ca
2 changes: 1 addition & 1 deletion frontend/public/data/portfolios.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export type PortfolioMember = {
export enum PortfolioRole {
DIRECTOR = "Director",
SUBCOM = "Subcommittee",
};
}

export const PORTFOLIOS: PortfolioData[] = [
{
Expand Down
13 changes: 2 additions & 11 deletions frontend/src/components/About/PortfolioDisplay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,12 @@
import { useState } from "react";
import PortfolioCard from "./PortfolioCard";
import { PortfolioRole, PORTFOLIOS } from "../../../public/data/portfolios";
import { PORTFOLIOS } from "../../../public/data/portfolios";

const PortfolioDisplay = () => {
const [selectedPortfolio, setSelectedPortfolio] = useState("Careers");

const names = PORTFOLIOS.map(port => port.name);

const portfolioMember = (name: string, role: PortfolioRole) => {
return (
<div>
<p>{name}</p>
<p>{role}</p>
</div>
);
};


return (
<div>
<div className="flex justify-between max-w-full h-10 my-6 snap-x snap-mandatory overflow-scroll hide-scrollbar">
Expand Down
Loading