Skip to content

Add casting from owner constructor to basic_observer_ptr #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

cschreib
Copy link
Owner

@cschreib cschreib commented Jul 6, 2022

Fixes #12. This also fixes documentation errors for the basic_observer_ptr constructor.

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2022

Codecov Report

Merging #13 (3f64587) into main (08f687f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #13   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          295       299    +4     
=========================================
+ Hits           295       299    +4     
Impacted Files Coverage Δ
include/oup/observable_unique_ptr.hpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08f687f...3f64587. Read the comment docs.

@cschreib cschreib merged commit 57c0bb0 into main Jul 6, 2022
@cschreib cschreib deleted the observer_constructor branch July 6, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing explicit cast constructor for observer from observable
2 participants