Test helper improvements & Test 6.1.3 #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced a generic `run_csaf_tests` function to handle CSAF 2.0 and 2.1 test cases, reducing code duplication. Updated `test_helper` and validation tests to use the new approach, improving maintainability and clarity.
Introduce a new module `test_6_1_03` to validate circular product ID references in CSAF documents. This includes a `find_cycle` function to detect cycles and corresponding validation logic with test cases ensuring correctness.
Adjust validation error messages for SSVC decision points to reflect the updated version 2.0.0. Includes changes to error messages regarding unknown decision points and the order of values. These updates align with the new specification requirements.
oxisto
previously approved these changes
May 20, 2025
oxisto
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run_csaf_testsfunction to handle CSAF 2.0 and 2.1 test cases, reducing code duplication. Updatedtest_helperand validation tests to use the new approach, improving maintainability and clarity.test_6_1_03to validate circular product ID references in CSAF documents. This includes afind_cyclefunction to detect cycles and corresponding validation logic with test cases ensuring correctness.