-
Notifications
You must be signed in to change notification settings - Fork 0
CSAF Tests 6.1.43 to 6.1.49 #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9155d6e
to
c334a86
Compare
Introduces a new validation function `test_6_1_43` to ensure model numbers in the CSAF document do not contain multiple unescaped asterisks. Includes corresponding unit tests to verify compliance with the requirement.
Introduce a new rule, test_6_1_44, to enforce restrictions on serial numbers in the CSAF document. The validation ensures serial numbers do not contain multiple unescaped asterisks and includes corresponding unit tests for compliance.
Updated the schema and related code, aligning with standard conventions. Added a new validation (test_6_1_45) to ensure disclosure dates are consistent with revision history. Adjusted logic, getters, and test cases accordingly.
This commit introduces the SSVC 1.0.1 schema definition, including JSON schema validation and data structure implementation. It integrates the new schema into the build system and ensures that the datetime handling is configurable when processing schemas.
Introduced a validation function `test_6_1_46_invalid_ssvc` to ensure proper SSVC object structure in vulnerabilities' metrics. Updated schemas, traits, and implementations to support SSVC content validation.
Implemented a new validation function, `test_6_1_47_inconsistent_ssvc_id`, to ensure SSVC IDs in the document adhere to expected constraints. This includes checks against the document ID, CVE, and vulnerability IDs. Updated necessary traits and getter implementations to support this functionality.
Introduce validation for SSVC decision points in CSAF documents, ensuring correctness and order of values. Added the corresponding schema definition for decision points for better type safety and compliance. Refactored to use `LazyLock` for cleaner regex handling.
Moved SSVC decision point initialization to a helper module for better modularity and reuse. Simplified `test_6_1_48` logic by leveraging the centralized `CSAF_SSVC_DECISION_POINTS` and `DP_VAL_LOOKUP` structures.
32f5de2
to
a8623e1
Compare
The decision point keys now incorporate a namespace component along with name and version, ensuring more precise identification and preventing potential conflicts. Adjusted related validation messages and logic to reflect the updated structure.
Implement test 6.1.49 to ensure that SSVC timestamps are earlier or equal to the newest revision date for documents with "final" or "interim" status.
b07165c
to
032d017
Compare
Fix für die fehlerhaften Test-JSONs ist in Arbeit: oasis-tcs/csaf#946 |
3ce5df2
to
6b09ee9
Compare
Introduce a `REGISTERED_SSVC_NAMESPACES` static set to track valid namespaces for SSVC. This ensures that unregistered namespaces are skipped during validation in `test_6_1_48_ssvc_decision_points`.
6b09ee9
to
e306c8f
Compare
oxisto
previously approved these changes
Apr 25, 2025
Ignoring test case 3.1.37 until oasis-tcs/csaf#963 is settled. |
oxisto
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add remaining mandatory tests.