adds ProxyFix for Cloud9 #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kzidane mind taking a look? |
dmalan
commented
Dec 29, 2018
src/cs50/flask.py
Outdated
| @@ -22,7 +22,7 @@ | |||
|
|
|||
| # Add support for Cloud9 proxy so that flask.redirect doesn't redirect from HTTPS to HTTP | |||
| # http://stackoverflow.com/a/23504684/5156190 | |||
| if getenv("C9_HOSTNAME") and not getenv("IDE_OFFLINE"): | |||
| if getenv("C9_PROJECT") == "ide50" and not getenv("IDE_OFFLINE"): | |||
There was a problem hiding this comment.
How come better, @kzidane?
There was a problem hiding this comment.
C9_HOSTNAME is set offline as well.
There was a problem hiding this comment.
But that's why we're checking and not getenv("IDE_OFFLINE") too, no?
There was a problem hiding this comment.
Well, in that case we could just check for IDE_OFFLINE really since it's not set online. C9_PROJECT is set to a different value online ("ide50") vs offline ("ide50-offline").
There was a problem hiding this comment.
That'd be different logic. We need the ProxyFix iff using CS50 IDE Online.
kzidane
previously approved these changes
Dec 29, 2018
This reverts commit 7383f11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This monkey-patches
flask.Flaskso thatappis wrapped with http://werkzeug.pocoo.org/docs/0.14/contrib/fixers/#werkzeug.contrib.fixers.ProxyFix on Cloud9 (online), which ensuresflask.redirectwon't redirect from HTTPS to HTTP. Sample app intests/redirect/.Seems best to monkey-patch rather than add, e.g., http://stackoverflow.com/a/23504684/5156190 to students' own
application.pyfiles, lest they reuse that file on a non-proxied setup, which isn't recommended: