Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stream file contents in cs3iface/readfile #136

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix: stream file contents in cs3iface/readfile #136

merged 1 commit into from
Nov 24, 2023

Conversation

DeepDiver1975
Copy link
Contributor

fixes #134

@DeepDiver1975 DeepDiver1975 changed the title fix: stream file contents in cs4iface/readfile fix: stream file contents in cs3iface/readfile Nov 24, 2023
glpatcern
glpatcern approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@glpatcern glpatcern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DeepDiver1975! The change is even smaller than what I thought ;-)

@glpatcern glpatcern merged commit 9a5a7a8 into cs3org:master Nov 24, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glpatcern glpatcern glpatcern approved these changes

@javfg javfg Awaiting requested review from javfg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

high memory usage when opening a largish file
2 participants
@DeepDiver1975 @glpatcern