fix: cephmount: call GetQuota on received path, not on root #5486
Conversation
labkode
commented
Jan 23, 2026
labkode
commented
- Calls GetQuota on the passed path vs the root mountpoint.
- Remove unused function.
labkode
requested review from
diocas,
glpatcern,
jessegeens and
rawe0
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
Thanks Hugo, just reporting here the comment in the chat
| maxQuotaData, err := xattr.Get(fullPath, "ceph.quota.max_bytes") | ||
| if err != nil { | ||
| log.Debug().Msg("cephmount: user.quota.max_bytes xattr not set, using default") | ||
| log.Debug().Msg("cephmount: ceph.quota.max_bytes xattr not set, using default") |
There was a problem hiding this comment.
So here we should traverse the tree to the top, looking for quota attributes and return the lowest value, defaulting to the whole mount only if none is found, right?
There was a problem hiding this comment.
And even if we go for a basic approach with no hierarchy of quotas (which I think it's fine), how do we know which node of the path holds the attribute? Or is this function only called at the root of the "Space"? cc @jessegeens
There was a problem hiding this comment.
The GetQuota call is made to the requested path, if the attribute is recursively applied to all directories, there is no need to go up in the parents.
There was a problem hiding this comment.
ok then I was not clear in what is "recursive": the quota is (recursively) applied to all directories down the tree, but there's no attribute visible anywhere except at the quota node, so one has to traverse the parents to get there
2 participants
