Skip to content

[Build-deps]: Bump github.com/dolthub/go-mysql-server from 0.14.0 to 0.20.0 #5172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 19, 2025

Bumps github.com/dolthub/go-mysql-server from 0.14.0 to 0.20.0.

Release notes

Sourced from github.com/dolthub/go-mysql-server's releases.

May 2025 Release

This is a periodic rollup release of features, bug fixes, and performance improvements. Interfaces are not guaranteed to stabilize until 1.0.

Merged PRs

go-mysql-server

  • 2974: fixval.TextStorage panic fixes: dolthub/dolt#9202
  • 2973: implement quote MySQL Docs: https://dev.mysql.com/doc/refman/8.4/en/string-functions.html#function_quote
  • 2972: make bit type columns with default values round trippable fixes: dolthub/dolt#9194
  • 2967: Unwrap wrapped values before computing their hash. (This PR changes the types in one of the tables used in tests. This improves the test coverage for TEXT columns, especially when they're used in conjunction with other tables with VARCHAR columns. None of the existing tests were testing the original type: this should be strictly increasing our test coverage.) The following plans involve computing a hash of rows to store in an in-memory hash set:
    • Intersect, Except, and Distinct
    • HashLookup
    • InSubquery
    • HashSubquery
    • FullJoinIter
    • ConcatJoin
    • Recursive CTE
    • UpdateJoinIter We weren't previously unwrapping wrapped values before computing hashes. The default hash implementation used the struct's %v representation to compute the hash, which has two problems:
    • The hash of the %v representation of a wrapper struct is not the same as the hash of the value that the wrapper is semantically equivalent to.
    • The hash of the %v representation of a wrapper struct depends on internal state, such as whether the wrapped has already been unwrapped once before (and cached the unwrapped value in an internal buffer) The simplest fix is to unwrap values before computing a row hash in the HashOf function. However, this fix comes at a cost: it now requires the engine to unwrap all values if they get used in any of the above plans. This will hurt performance for any of the above plans if they don't actually need to unwrap the value. For example, an UpdateJoinIter on a table with a TEXT column will now load that column from disk, even if its value is never used. A better fix might be to use the Hash() function that is already defined on the sql.Wrapper interface. For all existing Wrapper implementations, this returns the Dolt content address of the value, and is the same regardless of whether or not that address has previously been resolved. However, this would still return a different hash than an equivalent string. If we wanted them to return the same hash, Dolt would need to define a custom hash for strings that computes the Dolt content address of the string if it were to be stored as a Dolt chunk. This would likely be slower than Go's builtin hash for strings, although the performance might be comparable? This would likely result in worse performance for plans that don't use TEXT columns.
  • 2966: Fix float to bigint conversion result Fixes: dolthub/dolt#9178 Test to be added to dolt engine tests
  • 2964: Unwrap inputs to REGEXP_LIKE, REPLACE, and RPAD/LPAD functions. These are a couple more functions whose inputs aren't being unwrapped. If the inputs come from a column with a TEXT type, then they won't be converted to strings and the functions will fail. This PR fixes this by making sure that the inputs are converted. We missed this previously because although we have tests for these functions, none of them tested getting the inputs from TEXT columns of a table.
  • 2963: From unixtime Merged main from dolthub/go-mysql-server#2910
  • 2962: fix infinite recursion with recursive stored procedures fixes: dolthub/dolt#8763
  • 2961: fix prepare statements and user vars in stored procedures This PR adds tests for user variables within Stored Procedures. Additionally, this PR has changes so that we don't double parse PREPARE ... FROM ... statements, which also allows them to be used in the updated Stored Procedures call. fixes: dolthub/dolt#8911
  • 2959: Doltgres literal support This makes literal expression implement the sqlparser.Injectable interface so they can be used in Doltgres AST conversion. Also exports fields so literals can be edited in place (required for how Doltgres processes these in a couple places). This is an alternative to dolthub/go-mysql-server#2946.
  • 2958: Correctly map enum values when altering an enum column. When altering the possible values of an enum column, the mapping between enum strings and their indexes may change. In order to alter the column correctly, we need to map the old indexes onto the new ones.

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/dolthub/go-mysql-server](https://github.com/dolthub/go-mysql-server) from 0.14.0 to 0.20.0.
- [Release notes](https://github.com/dolthub/go-mysql-server/releases)
- [Commits](dolthub/go-mysql-server@v0.14.0...v0.20.0)

---
updated-dependencies:
- dependency-name: github.com/dolthub/go-mysql-server
  dependency-version: 0.20.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested review from glpatcern, gmgigi96 and labkode May 19, 2025 00:48
@dependabot dependabot bot requested a review from diocas as a code owner May 19, 2025 00:48
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 19, 2025
@dependabot dependabot bot requested a review from jessegeens as a code owner May 19, 2025 00:48
@dependabot dependabot bot added the go Pull requests that update Go code label May 19, 2025
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github May 19, 2025

The reviewers field in the dependabot.yml file will be removed soon. Please use the code owners file to specify reviewers for Dependabot PRs. For more information, see this blog post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants