Cindyrzheng/dropclass

[cindyrzheng]

some drop class stuff, has been weirldy merged so need to review rn

[1strangequark]

This all looks good to me, Cindy.

[cindyrzheng]

This all looks good to me, Cindy.

Rolled back to when Jonathan wrote this, and then changed an error statement.

[cindyrzheng]

Still have not tested this since Im not too sure how to get ahold of a student ID

[cindyrzheng]

Left as a draft since I'm getting a 400 bad request response. will investigate more in the morn! gotta sleep now :(

[cindyrzheng]

cindyzheng@Cindys-MacBook-Pro backend % curl -X POST localhost:8080/class/1/drop -H 'Content-Type: application/json' -H 'Authorization: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZXhwIjoxNjQ5MjM0ODk2LCJuYmYiOjE2NDY2NDI4OTZ9.bEHhDL_ztP2_xc7-M66A6nlXg9Xei7nNIG1WCV-rv94' -d ‘{“classId”:”1”,”studentId”:”1”}’
curl: (3) URL using bad/illegal format or missing URL

Not sure what's going on but I think there might be a problem with the drop endpoint! @pkrish20 @svetly-t @krashanoff

[krashanoff]

Move your URL to the end of the cURL command.

[cindyrzheng]

eyJpZCI6MSwiZXhwIjoxNjQ5MjM0ODk2LCJuYmYiOjE2NDY2NDI4OTZ9.bEHhDL_ztP2_xc7-M66A6nlXg9Xei7nNIG1WCV-rv94' -d ‘{“classId”:”1”,”studentId”:”1”}’

cindyzheng@Cindys-MacBook-Pro backend % curl -X POST -H 'Content-Type: application/json' -H 'Authorization: eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpZCI6MSwiZXhwIjoxNjQ5MjM0ODk2LCJuYmYiOjE2NDY2NDI4OTZ9.bEHhDL_ztP2_xc7-M66A6nlXg9Xei7nNIG1WCV-rv94' -d ‘{“classId”:”1”,”studentId”:”1”}’  localhost:8080/class/1/drop
curl: (3) URL using bad/illegal format or missing URL 

😭

[krashanoff]

The issue you're encountering in your command is malforming the cURL command - that's why it says curl: (3) URL using.... That's not something from our server, but cURL. I think it's because you're using weird double-quotes, rather than standard ASCII ones (see {“classId”:”1”,”studentId”:”1”} compared to {"classId": "1", "studentId": "1"}). The following commands run fine for me:

Anyways, there were a few things wrong in the command, and I messed up a few times using it here anyways. On the left side, you can see the output of the backend, and on the right, my commands. We can see that the server complained that our request was bad a few times (400). Fixing the format by changing it to use id instead of studentId, we then we got an auth issue a few times (401) because we tried to drop the professor from the class. Changing the id field to the student ID, 2, the request succeeds.

[krashanoff]

Looks good following some nits!