Skip to content

Conversation

davidism
Copy link
Contributor

@davidism davidism commented May 6, 2022

  • I have added an entry to CHANGELOG.md, or an entry is not needed for this change

Summary of changes

Add a dependency on eventlet. Flask-SocketIO uses this instead of the Werkzeug development server if it is installed. Flask-SocketIO recommends eventlet for performance as well.

Remove a line (now unneeded) that caused the Werkzeug development server to crash with Werkzeug 2.1.

fixes #425

Test plan

Run the develop command, observe that the server starts as expected.

nox -s develop

@cs01
Copy link
Owner

cs01 commented Jun 22, 2022

I tested this out, and it works. Thanks! I will release a new version soon with this fix.

@cs01 cs01 merged commit 9be90ff into cs01:master Jun 22, 2022
@davidism davidism deleted the werkzeug-compat branch July 6, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fails to start with KeyError: WERKZEUG_SERVER_FD

2 participants