Skip to content

Conversation

@cs-util
Copy link

@cs-util cs-util commented Oct 13, 2025

This pull request focuses on improving repository standards, agent guidelines, and configuration files to streamline development, testing, and agent automation. The main changes include establishing a canonical agent instruction file (AGENTS.md), updating quality gate requirements, cleaning up and improving configuration files for tools like ESLint, Jest, and jscpd, and enhancing documentation to reflect these updates.

Agent and Development Guidelines

  • Added a new AGENTS.md at the repository root as the canonical source for agent instructions, covering development standards, project structure, testing strategy, feature development process, and TDD workflow. This replaces and consolidates previous guidance from .github/copilot-instructions.md. [1] [2]
  • Updated docs/autonomous-agents-setup.md to reference AGENTS.md as the single source of truth for agent guidelines, quality gates, and validation steps. Clarified agent workflows, templates, and best practices throughout the documentation. [1] [2] [3] [4] [5]

Quality Gates and Testing Requirements

  • Lowered the mutation testing pass threshold from >80% to >50% in the agent task issue template to make quality gates more practical for agents.
  • Updated Jest configuration to require 90% coverage across all metrics, ignore additional test artifact directories, and ensure ESM compatibility via Babel transform.
  • Improved code duplication detection (.jscpd.json) by excluding temporary and report directories used by mutation and UI testing tools.

Configuration and Linting Improvements

  • Enhanced ESLint configuration to ignore generated and report directories regardless of invocation location, improving local and CI developer experience.
  • Added a Prettier configuration (.prettierrc.json) to enforce consistent code formatting across the project.
  • Updated dependency-cruiser config to exclude mutation and UI test report directories and improved formatting for clarity.

Template and Documentation Cleanup

  • Removed the default pull request template (.github/PULL_REQUEST_TEMPLATE.md) to encourage more focused, agent-driven PR descriptions.
  • Updated references in documentation and templates to point to the new canonical AGENTS.md file and improved clarity throughout. [1] [2]

These changes collectively improve the maintainability, clarity, and automation-readiness of the repository for both human contributors and autonomous agents.

…era flow: we still catch console/page errors, but now assert the main nav, Camera tab state, camera-view visibility, empty-state guidance, CTA label, hidden file input wiring, and canvas wrapper default
@gemini-code-assist
Copy link

Summary of Changes

Hello @cs-util, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refines the repository's development and automation standards, primarily by centralizing agent guidance and updating various tooling configurations. The changes aim to streamline workflows for both human contributors and autonomous agents, ensuring consistent code quality, more practical testing thresholds, and a clearer, more maintainable documentation structure. A new E2E testing framework has also been integrated to enhance application stability.

Highlights

  • Agent Guidelines Consolidation: A new canonical AGENTS.md file has been introduced at the repository root, centralizing all agent instructions, development standards, testing strategies, and TDD workflows. This replaces and consolidates previous guidance from .github/copilot-instructions.md and updates references across documentation.
  • Quality Gate Adjustments: The mutation testing pass threshold in the agent task issue template has been lowered from >80% to >50% to make quality gates more practical. Jest configuration now requires 90% coverage across all metrics (branches, functions, lines, statements) and includes Babel transform for ESM compatibility. The code-quality-specification.md has been updated to reflect these new thresholds.
  • Configuration and Linting Improvements: ESLint configuration has been enhanced with more robust ignore patterns for generated directories. A Prettier configuration (.prettierrc.json) has been added to enforce consistent code formatting. Dependency-cruiser and jscpd configurations have been updated to exclude temporary and report directories, improving accuracy and developer experience.
  • New E2E Testing Setup: End-to-end testing has been introduced using Playwright, with new configuration files (playwright-ui-tests/playwright.config.js) and a smoke test (playwright-ui-tests/index.spec.js) to ensure the static index.html loads without console errors. Related scripts have been added to package.json.
  • Documentation Streamlining: Several outdated or redundant documentation files (docs/gemini-bboxes.md, docs/implementation-progress.md, docs/pwa-cache-refresh-spec.md) have been removed. Existing documentation, such as docs/autonomous-agents-setup.md and docs/code-quality-specification.md, has been updated for clarity and to reference the new AGENTS.md.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the repository's structure and development standards by consolidating agent instructions into a canonical AGENTS.md, updating quality gate configurations, and introducing consistent code formatting with Prettier. The changes are well-organized and enhance maintainability. I've identified one critical syntax error in package.json and a few minor style issues that should be addressed.

- Minimal local first web app (static HTML + modular JS)
- Entrypoint: `index.html` (+ static pages in `pages/`)
- Source composed of small, focused modules in `src/` (`components/`, `utils/`, ..) with colocated tests
- Frequently during development and before each commit: run `npm test`

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a minor typo here: a trailing space at the end of the line. It should be removed for consistency and to prevent potential issues with tools that might parse this file.

Suggested change
- Frequently during development and before each commit: run `npm test`
- Frequently during development and before each commit: run `npm test`

- Keep tests deterministic and fast; avoid E2E unless asked

## TDD Failure loop to use
1. Prefer the simplest fix first

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a minor typo here: a trailing space at the end of the line. It should be removed for consistency.

Suggested change
1. Prefer the simplest fix first
1. Prefer the simplest fix first

@cs-util cs-util merged commit 5e1e820 into main Oct 13, 2025
4 of 6 checks passed
@cs-util cs-util deleted the v4 branch October 13, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants