-
Notifications
You must be signed in to change notification settings - Fork 62
Update 03-intermediateJS(I).md for Technical Assistant v3.0 #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 03-intermediateJS(I).md for Technical Assistant v3.0 #316
Conversation
Create The Process of Making Structural Change in CS Internship - Cre…
Update Update Interns Profile --fa.md
Update Queue Check --fa.md
Update Technical Assistant Role and Guidelines - minor fixes
Update CS Internship Overview - Update Entrance Process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @Ali-Sdg90, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on a substantial update and refinement of the CS Internship program's documentation. The changes aim to provide clearer guidelines for participants, streamline administrative processes like admissions and interview onboarding, enhance the clarity of roles such as Technical Assistant, and introduce a new framework for managing structural changes within the program. The updates also include a significant reorganization of the intern profile management guide.
Highlights
- Internship Guidelines Update: The guidelines for interns in 'Intermediate JS (I)' have been significantly expanded and clarified, detailing posting requirements, the importance of consistent activity, weekly reporting, and technical session scheduling.
- Admission Process Streamlining: The 'CS Internship Overview' document has been revised to provide a more concise and integrated explanation of the program's admission process, combining several previously separate sections.
- Interview Onboarding Process Detail: The 'Queue Check' document now includes a more detailed, step-by-step guide for onboarding interview candidates, clarifying the responsibilities of the queue manager.
- Technical Assistant Role Refinements: Minor textual corrections and clarifications have been applied to the 'Technical Assistant Role and Guidelines' document, improving readability and accuracy.
- New Structural Change Process Document: A new document titled 'The Process of Making Structural Change in CS Internship' has been added, outlining a formal procedure for implementing structural modifications within the program.
- Intern Profile Management Overhaul: The 'Update Interns Profile' document has undergone a comprehensive rewrite and restructuring, offering a clearer and more organized guide for managing intern profiles, including coordinator responsibilities and training.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request focuses on updating and standardizing several process documents for the CS Internship program. The changes significantly improve the clarity, structure, and readability of the guidelines, especially in the Persian-language documents. My review includes suggestions to fix a few typos, improve formatting consistency, and address minor language inconsistencies to further enhance the quality of the documentation.
| # راهنمای نقش همیار فنی و دستورالعملهای آن | ||
| ## مقدمه | ||
| خدمت و تعهد موتور محرکه برنامه CS Internship است. هر اینترن در استپ سوم با نقش همیار فنی وارد چرخه ارائه خدمت میشود. اینترن در این نقش، جلساتی را تحت عنوان همیاری فنی برای همدورهایهای استپهای قبلی برگزار میکند. هدف این جلسات آن است که اینترنها در طول استپهای خود بتوانند از بازخوردهای همیار فنی سطح بالاتر بهرهمند شوند و همچنین فرصت پرسش و دریافت پاسخ داشته باشند. | ||
| خدمت و تعهد موتور محرکه برنامه CS Internship است. هر اینترن در استپ سوم با نقش همیار فنی وارد چرخه ارائه خدمت میشود. اینترن در این نقش، جلساتی را تحت عنوان همیاری فنی برای همدورهایهای استپهای قبلی برگزار میکند. هدف این جلسات آن است که اینترنها در طول استپهای خود بتوانند از بازخوردهای همیار فنی سطح بالاتر بهرمند شوند و همچنین فرصت پرسش و دریافت پاسخ داشته باشند. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a typo was introduced here. The word «بهرهمند» (which is correct) was changed to «بهرمند» (which is a common misspelling). Please revert this to the correct spelling.
| خدمت و تعهد موتور محرکه برنامه CS Internship است. هر اینترن در استپ سوم با نقش همیار فنی وارد چرخه ارائه خدمت میشود. اینترن در این نقش، جلساتی را تحت عنوان همیاری فنی برای همدورهایهای استپهای قبلی برگزار میکند. هدف این جلسات آن است که اینترنها در طول استپهای خود بتوانند از بازخوردهای همیار فنی سطح بالاتر بهرمند شوند و همچنین فرصت پرسش و دریافت پاسخ داشته باشند. | |
| خدمت و تعهد موتور محرکه برنامه CS Internship است. هر اینترن در استپ سوم با نقش همیار فنی وارد چرخه ارائه خدمت میشود. اینترن در این نقش، جلساتی را تحت عنوان همیاری فنی برای همدورهایهای استپهای قبلی برگزار میکند. هدف این جلسات آن است که اینترنها در طول استپهای خود بتوانند از بازخوردهای همیار فنی سطح بالاتر بهرهمند شوند و همچنین فرصت پرسش و دریافت پاسخ داشته باشند. |
|
|
||
| **همیار فنی:** شخصی است که حداقل سه استپ از دوره خود را گذرانده و میتواند به اینترنهای همدورهای خود در مراحل پایینتر خدمت برساند. | ||
| **جلسه همیاری فنی:** جلسهای که اینترنهای طی گذراندن مراحل استپ خود در آنها شرکت کنند و نسبت به کزارشات خود بازخورد بگیرند، سوالات خود را مطرح کنند و از تجربیات افراد در استپهای جلوتر از خود بهرمند شود. | ||
| **جلسه همیاری فنی:** جلسهای که اینترنهای طی گذراندن مراحل استپ خود در آنها شرکت کنند و نسبت به گزارشات خود بازخورد بگیرند، سوالات خود را مطرح کنند و از تجربیات افراد در استپهای جلوتر از خود بهرمند شود. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While fixing one typo («کزارشات» to «گزارشات»), another one remains. The word «بهرمند» is a common misspelling of «بهرهمند». It would be great to correct this as well to improve the document's quality.
| **جلسه همیاری فنی:** جلسهای که اینترنهای طی گذراندن مراحل استپ خود در آنها شرکت کنند و نسبت به گزارشات خود بازخورد بگیرند، سوالات خود را مطرح کنند و از تجربیات افراد در استپهای جلوتر از خود بهرمند شود. | |
| **جلسه همیاری فنی:** جلسهای که اینترنهای طی گذراندن مراحل استپ خود در آنها شرکت کنند و نسبت به گزارشات خود بازخورد بگیرند، سوالات خود را مطرح کنند و از تجربیات افراد در استپهای جلوتر از خود بهرهمند شود. |
| ۳- **تسک (Task):** | ||
| یک وظیفه مشخص که اینترن باید در طول استپ انجام دهد. این وظایف شامل تمرینهایی مانند تایپ ده انگشتی، تحقیق درباره یک مفهوم یا انجام تمرینهای برنامهنویسی هستند. | ||
|
|
||
| ۴- **پروفایل:** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a small typo in the phrase «شرکت کنند». The zero-width non-joiner (ZWNJ) is used incorrectly here. It should be a regular space, as in «شرکت کنند».
| ۴- **پروفایل:** | |
| افرادی که علاقه به ورود به برنامه CS Internship را دارند، پس از ورود به [گروه تلگرامی صف](https://t.me/+5PuhQ2hDIy1lNWRi)، طی سه مرحله با اهداف، ساختارها، و قوانین اصلی این برنامه آشنا خواهند شد تا آگاهی کامل نسبت به برنامه را پیدا کنند. افراد در طی هر کدام از این سه مرحله میبایست، بعد از خواندن یک مستند و یا دیدن یک ویدیو در یک جلسه سوال و جواب در مورد برنامه شرکت کنند. در آن جلسه، شرکتکنندگان فرصت خواهند داشت در مورد مطالبی که در مستند یا ویدیو مطرح شده است صحبت کنند و هر نظر یا سوالی را که در مورد برنامه داشتند مطرح نمایند. افرادی که نیاز دارند، میتوانند در هر مرحله بیش از یک بار در جلسه پرسش و پاسخ آن مرحله شرکت کنند تا همه اطلاعاتی را که برای تصمیمگیری در مورد ورود به برنامه نیاز دارند به دست آورند. |
|
|
||
| ۲. پس از اضافهکردن متقاضی به گروه آنبوردینگ مصاحبه، در گروه صف پیام میگذارد و اعلام میکند که نوبت مصاحبهٔ ایشان رسیده و به گروه آنبوردینگ اضافه شدهاند. | ||
|
|
||
| ۳. متقاضی حداکثر سه روز فرصت دارد به دو سوال که در پیام پین شده گروه آنبوردینگ آورده شده جواب دهد. پس از دریافت پاسخ متقاضی، مسئول صف باید در تاپیک `interview` نتیجهٔ هر دو سوال را به مسئول مصاحبه اطلاع دهد و او را منشن کند. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed a couple of minor issues on this line that could be improved for clarity and consistency:
- Spelling: The word «سوال» is better written as «سؤال» in formal documents.
- Consistency: The topic name
interviewis in lowercase, but it was referred to asInterview(with a capital 'I') earlier in the document (line 121). It's best to use consistent casing for identifiers.
| ۳. متقاضی حداکثر سه روز فرصت دارد به دو سوال که در پیام پین شده گروه آنبوردینگ آورده شده جواب دهد. پس از دریافت پاسخ متقاضی، مسئول صف باید در تاپیک `interview` نتیجهٔ هر دو سوال را به مسئول مصاحبه اطلاع دهد و او را منشن کند. | |
| ۳. متقاضی حداکثر سه روز فرصت دارد به دو سؤال که در پیام پین شده گروه آنبوردینگ آورده شده جواب دهد. پس از دریافت پاسخ متقاضی، مسئول صف باید در تاپیک `Interview` نتیجهٔ هر دو سؤال را به مسئول مصاحبه اطلاع دهد و او را منشن کند. |
courses/web/03-intermediateJS(I).md
Outdated
| `#cs_internship` | ||
| `#[courseName]` | ||
| `#[stepNumber]` | ||
| - For each study item and task, you must publish at least one post on **LinkedIn**, **Twitter (X)**, and **Telegram**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
احتمال میدم که تو این جمله اینترنها این برداشت رو بکنن که حداقل یک پست باید در یکی از این شبکههای اجتماعی بگذارند.
پیشنهاد میکنم بنویسیم:
publish at least one post on each LinkedIn, Twitter (X), and Telegram.
يا یک طوری جلمه رو بنویسیم که بگیم برای هر تسک ۳ پست گذاشته شود. یکی در لینکدین و یکی در ایکس و دیگری در کلاب خودتان در تگلرام.
publish at least three posts. One post on LinkedIn, another on Twitter (X), and the other on Telegram.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
دان
courses/web/03-intermediateJS(I).md
Outdated
| `#[stepNumber]` | ||
| - For each study item and task, you must publish at least one post on **LinkedIn**, **Twitter (X)**, and **Telegram**. | ||
| - Your posts should reflect your actual activity. You’re expected to stay active and post on a **weekly basis**. | ||
| - Posting is the **primary way your progress is tracked**. It’s not necessary to have completed the item — you can share your **learning process** or **ongoing progress** in your posts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
بنظرم حتما کلمهی باید رو استفاده کنیم برای اینکه همه حین مطالعه پست بگذارند.
you should share your learning process or ongoing progress in your posts.
بنظرم به جای دو کلمه learning process و ongoing progress فقط کلمه Should بولد باشد.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
دان
courses/web/03-intermediateJS(I).md
Outdated
| ### Weekly Report | ||
|
|
||
| You will have a session with a technical mentor based on your report. | ||
| You must submit a weekly report to your coordinator using the official template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
بنظرم لینک تمپلیت رو اینجا هم بذاریم.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
دان
courses/web/03-intermediateJS(I).md
Outdated
| ### Study Items <!-- omit in toc --> | ||
| ### Technical Assistant Sessions | ||
|
|
||
| After spending 15 hours on activities since your last Technical Assistant Session, you should schedule a Technical Assistant Session. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
کلمه should بولد باشه بهتر هست.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
دان
courses/web/03-intermediateJS(I).md
Outdated
| 7. Follow at least 5 Twitter accounts that are active in web technologies. Describe why they are worth following. | ||
|
|
||
| 8. Exactly **7 days** before your deadline, ask your coordinator to schedule a live presentation session for you on your deadline day. | ||
| 8. You are now eligible and it is time to proceed with your promotion to **Level 1 Technical Assistant**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
فکر کنم ترتیب این «Level 1 Technical Assistant» اشتباه هست و باید باشه «Technical Assistant, Level 1»
باز این رو چک بکن مطمئن نیستم.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
دان
courses/web/03-intermediateJS(I).md
Outdated
| Read the following document and follow the instructions provided to complete the role transition. | ||
| [Technical Assistant Role and Guidelines](https://github.com/cs-internship/cs-internship-spec/blob/master/processes/documents/Technical%20Assistant%20Role%20and%20Guidelines%20--fa.md) | ||
|
|
||
| 9. You must have a session with a technical assistant on your step. In this session, the assistant will review your reports and activities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
بنظرم بهتر هست کلمه Technical Assistant بصورت بولد و Capital case نوشته بشه.
نمی دونم در داکیومنت هم گفتیم که فرق منتور فنی با همیار فنی چی هست. نکنه متوجه تفاوت نشن و اینجا هم با همیار فنی جلسه ست کنن.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
دان
اره تو داکیومنت توضیح میده که چه فرقی دارن. تو ویدئو آپدیت جدید ک به اینترن ها هم میدیم هم اینو تاکید میکنم
Ali-Sdg90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
سلام مریم @Marirood
مرسی بابت کامنتهای خیلی خوب. همشون اعمال شد :»
courses/web/03-intermediateJS(I).md
Outdated
| `#cs_internship` | ||
| `#[courseName]` | ||
| `#[stepNumber]` | ||
| - For each study item and task, you must publish at least one post on **LinkedIn**, **Twitter (X)**, and **Telegram**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
دان
courses/web/03-intermediateJS(I).md
Outdated
| `#[stepNumber]` | ||
| - For each study item and task, you must publish at least one post on **LinkedIn**, **Twitter (X)**, and **Telegram**. | ||
| - Your posts should reflect your actual activity. You’re expected to stay active and post on a **weekly basis**. | ||
| - Posting is the **primary way your progress is tracked**. It’s not necessary to have completed the item — you can share your **learning process** or **ongoing progress** in your posts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
دان
courses/web/03-intermediateJS(I).md
Outdated
| ### Weekly Report | ||
|
|
||
| You will have a session with a technical mentor based on your report. | ||
| You must submit a weekly report to your coordinator using the official template. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
دان
courses/web/03-intermediateJS(I).md
Outdated
| ### Study Items <!-- omit in toc --> | ||
| ### Technical Assistant Sessions | ||
|
|
||
| After spending 15 hours on activities since your last Technical Assistant Session, you should schedule a Technical Assistant Session. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
دان
courses/web/03-intermediateJS(I).md
Outdated
| 7. Follow at least 5 Twitter accounts that are active in web technologies. Describe why they are worth following. | ||
|
|
||
| 8. Exactly **7 days** before your deadline, ask your coordinator to schedule a live presentation session for you on your deadline day. | ||
| 8. You are now eligible and it is time to proceed with your promotion to **Level 1 Technical Assistant**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
دان
courses/web/03-intermediateJS(I).md
Outdated
| Read the following document and follow the instructions provided to complete the role transition. | ||
| [Technical Assistant Role and Guidelines](https://github.com/cs-internship/cs-internship-spec/blob/master/processes/documents/Technical%20Assistant%20Role%20and%20Guidelines%20--fa.md) | ||
|
|
||
| 9. You must have a session with a technical assistant on your step. In this session, the assistant will review your reports and activities. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
دان
اره تو داکیومنت توضیح میده که چه فرقی دارن. تو ویدئو آپدیت جدید ک به اینترن ها هم میدیم هم اینو تاکید میکنم
|
/gemeni re-review |
|
/gemini re-review |
|
Hi Ali-Sdg90, It looks like you're trying to request a re-review of your pull request. The command for initiating a code review is The command If you need to see a list of all available commands, you can always use |
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several documentation files related to the CS Internship program. The changes significantly improve the structure, clarity, and readability of the documents, especially by refactoring long paragraphs into structured lists and sections. The PR also fixes numerous typos across the files and adds a new template document. Overall, these are great improvements. I've found a couple of minor issues: a new typo was introduced in one file, and another has a duplicated heading. Please see my detailed comments.
No description provided.