Fix AssertionError crash in reorder_arguments for misresolved structs#2957
Open
kazzarahw wants to merge 2 commits intocrytic:masterfrom
Open
Fix AssertionError crash in reorder_arguments for misresolved structs#2957kazzarahw wants to merge 2 commits intocrytic:masterfrom
kazzarahw wants to merge 2 commits intocrytic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reorder_argumentswith a filter that skips mismatcheddecl_namesentries and returns args unmodified when no entry matches.convert_constant_typesfor the same scenario (IndexErroronst.elems_ordered[idx]).Root cause
reorder_argumentscrashes with anAssertionErrorwhendecl_namescontains entries whose length doesn't match the call argument count. This happens when Slither misresolves a struct to a same-named struct with a different number of fields (e.g. two structs namedPlasmaVaultAddressin different files, one with 7 fields and one with 1).Fixes #2217