Skip to content
This repository was archived by the owner on Feb 24, 2023. It is now read-only.

Conversation

@montyly
Copy link
Contributor

@montyly montyly commented Apr 24, 2020

No description provided.

@montyly
Copy link
Contributor Author

montyly commented Apr 24, 2020

@@ -0,0 +1,37 @@
## State variable shadowing

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no link to this document in the main README.md.

@@ -0,0 +1,21 @@
## Incorrect erc20 interface

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this makes sense but should there be a generalized rule that all interfaces should be correctly configured to return the correct value? This same type of bug could occur in cases where a developer uses a custom or non ERC-20/721 interface?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants