Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshot and revertTo bug fix #455

Closed
wants to merge 2 commits into from
Closed

snapshot and revertTo bug fix #455

wants to merge 2 commits into from

Conversation

damilolaedwards
Copy link
Contributor

closes issue #373, fix applied to medusa-geth. The snapshot and revertTo cheatcodes now use the updated function.

@anishnaik
Copy link
Collaborator

This issue needs more investigation. The logic on how to persist snapshots in medusa-geth does not seem to be sufficient to assert that you can time-travel across snapshots. Currently, the test case for this PR reverts snapshots in reverse order (3, 2, 1) - whereas the correct test for this would revert in (1, 2, 3) order. This test would allow you to ensure that you can snapshot to 1 and then snapshot to 3 and all state changes can be asserted on.

I tried changing the unit test and we are failing to properly handle snapshots/reverts.

@0xalpharush 0xalpharush marked this pull request as draft August 26, 2024 16:50
@0xalpharush 0xalpharush closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xenomega Xenomega Awaiting requested review from Xenomega Xenomega is a code owner

@anishnaik anishnaik Awaiting requested review from anishnaik anishnaik is a code owner

@0xalpharush 0xalpharush Awaiting requested review from 0xalpharush

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damilolaedwards @anishnaik @0xalpharush