Skip to content

Stop removing spaces in ABI #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2025
Merged

Stop removing spaces in ABI #597

merged 2 commits into from
Apr 28, 2025

Conversation

samalws-tob
Copy link
Contributor

This was causing issues in medusa where geth was unable to parse contractContractName when it was expecting contract ContractName
see https://github.com/ethereum/go-ethereum/blob/c8c8d6c4039a476478dfcfb732ba83822b648288/accounts/abi/type.go#L222-L227 for the parser code

@elopez elopez changed the base branch from master to dev April 28, 2025 22:30
@elopez elopez added this pull request to the merge queue Apr 28, 2025
Merged via the queue into dev with commit 8747a12 Apr 28, 2025
60 checks passed
@elopez elopez deleted the stop-removing-spaces branch April 28, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants