Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Migrate ::set-env -> $GITHUB_ENV #9850

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Conversation

oprypin
Copy link
Member

@oprypin oprypin commented Oct 25, 2020

Fixes #9785

@bcardiff bcardiff added platform:windows Windows support based on the MSVC toolchain / Win32 API topic:infrastructure labels Oct 26, 2020
@bcardiff bcardiff added this to the 1.0.0 milestone Oct 26, 2020
@bcardiff bcardiff merged commit 0cfcead into crystal-lang:master Oct 26, 2020
@bcardiff
Copy link
Member

@oprypin would you know why windows builds on fork fails? https://github.com/bcardiff/crystal/runs/1333647009?check_suite_focus=true it seems the timeout in my fork due to llvm build, is that expected?

This is not new to this PR, I think my fork just never succeeded on a windows build. Which is unfortunate because I discover missing bits when submitting PRs only.

@oprypin
Copy link
Member Author

oprypin commented Oct 31, 2020

@bcardiff The only reasonable explanation I can see is that at some point the environment of GitHub Actions changed so that this build always breaks, but the cache never expired in the main repo so it still appears OK. I have noticed this problem but have not figured out a solution (although I haven't dug deep at all).

@oprypin
Copy link
Member Author

oprypin commented Oct 31, 2020

So it's not a timeout and there actually is relevant output.

https://github.com/bcardiff/crystal/runs/1333355667?check_suite_focus=true#step:20:1623

D:\a\crystal\crystal\llvm-src\include\llvm/ADT/SmallVector.h(315,32): error C2976: 'llvm::SmallVectorTemplateBase': too few template arguments (compiling source file D:\a\crystal\crystal\llvm-src\lib\ExecutionEngine\RuntimeDyld\RTDyldMemoryManager.cpp) [D:\a\crystal\crystal\llvm-src\lib\ExecutionEngine\RuntimeDyld\LLVMRuntimeDyld.vcxproj]
D:\a\crystal\crystal\llvm-src\include\llvm/ADT/SmallVector.h(179): message : see declaration of 'llvm::SmallVectorTemplateBase' (compiling source file D:\a\crystal\crystal\llvm-src\lib\ExecutionEngine\RuntimeDyld\RTDyldMemoryManager.cpp) [D:\a\crystal\crystal\llvm-src\lib\ExecutionEngine\RuntimeDyld\LLVMRuntimeDyld.vcxproj]

Must have been a compiler update.

@oprypin
Copy link
Member Author

oprypin commented Oct 31, 2020

Tried to bump LLVM minor version, that didn't help
https://github.com/oprypin/crystal/actions/runs/339148829

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform:windows Windows support based on the MSVC toolchain / Win32 API topic:infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare Windows GitHub Action for upcoming deprecations
3 participants