Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling errors #9844

Merged
merged 1 commit into from
Oct 26, 2020
Merged

Fix spelling errors #9844

merged 1 commit into from
Oct 26, 2020

Conversation

camreeves
Copy link
Contributor

A friend created a long list (3500+ entries) with cspell for the codebase and I've manually corrected a bunch.

A thank you to @caspiano for the initial list.

Copy link
Member

@jhass jhass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope nobody depends on the misspelled error message :D

@bcardiff bcardiff added this to the 1.0.0 milestone Oct 23, 2020
@jhass
Copy link
Member

jhass commented Oct 24, 2020

I wonder if we can have something like this as a CI check / GitHub review bot thingy?

@camreeves
Copy link
Contributor Author

camreeves commented Oct 24, 2020

I wonder if we can have something like this as a CI check / GitHub review bot thingy?

That’s definitely possible to some extent. I found that looking for common digraphs but with the letters transposed led to finding typos in the list much quicker but I do fear that automating it would produce lots of false positives.

@jhass
Copy link
Member

jhass commented Oct 24, 2020

Ah, I didn't realize you filtered by hand. Nevermind me and thank you! :)

@bcardiff bcardiff merged commit 5b180e6 into crystal-lang:master Oct 26, 2020
@camreeves camreeves deleted the patch-1 branch October 26, 2020 14:00
@bcardiff
Copy link
Member

Thank you @camreeves. 🙇 Those were a lot of tpos!

@docelic docelic mentioned this pull request Oct 26, 2020
straight-shoota pushed a commit that referenced this pull request Oct 30, 2020
Similar to fixes done in #9844.
@docelic docelic mentioned this pull request Oct 31, 2020
bcardiff pushed a commit that referenced this pull request Nov 6, 2020
* Fix spelling errors (3)

Similar to fixes done in #9844 and #9854.

This commit completes the review of all files in the repository.

* Fix spelling errors (3.1)

* Undo an incorrect word replacement.

Thanks @makenowjust for pointing it out in #9854.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants