Codegen: promote C variadic args as needed #9747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
jhass
approved these changes
Sep 15, 2020
| call_arg = extend_float @program.float64, call_arg | ||
| elsif arg_type.is_a?(IntegerType) && arg_type.kind.in?(:i8, :u8, :i16, :u16) | ||
| # Integer with a size less that `int` must be converted to `int` | ||
| call_arg = extend_int arg_type, @program.int32, call_arg |
There was a problem hiding this comment.
So I guess technically this should check what the target platform C int type is, but in practice all platforms we support so far have int = int32_t. Just something to keep in mind in case somebody wants to target something weird or old.
There was a problem hiding this comment.
Yeah, I thought of this and reached the same conclusion. Also, I don't know how to know what's the target platform size of int.
There was a problem hiding this comment.
sizeof(LibC::Int) ? Or that is perhaps only the local compiler size of it?
There was a problem hiding this comment.
That's the size of the host machine. It won't work when cross-compiling.
oprypin
approved these changes
Sep 17, 2020
bcardiff
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9742