Docs: Add a note regarding Log.setup #9497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardiff
approved these changes
Jun 18, 2020
Sija
reviewed
Jun 18, 2020
caspiano
force-pushed
the
docs/clarify-log-setup
branch
from
446f0d6 to
c20e940
Compare
jhass
added
kind:docs
pr:ready-to-merge
jhass
approved these changes
Jun 19, 2020
bcardiff
added
topic:stdlib:log
and removed
pr:ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a small note regarding the behaviour of
Log.setup.I got shot in the foot by following the example in the docs thinking it would "setup" for the sources defined, and not override previous setup calls.