Fix: realpath on macOS 10.15 (Catalina) #9296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waj
added
kind:bug
asterite
approved these changes
May 13, 2020
RX14
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the alternative symbol
realpath$DARWIN_EXTSNin macOS. Apparently the original symbol (realpath) is not working on 10.15 and it's returingEONENTinstead.When using
realpathin a C program the linked function is_realpath$DARWIN_EXTSNso I think we should do the same. I tried to find when was that function introduced and apparently it was around 10.5 (https://newsgroup.xnview.com/viewtopic.php?t=18491). That is, more than 10 years ago. So it's probably safe to use it for any macOS version.Closes #8547, #8431