Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip explicit creation of docs/ dir #8718

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Skip explicit creation of docs/ dir #8718

merged 1 commit into from
Jan 27, 2020

Conversation

Sija
Copy link
Contributor

@Sija Sija commented Jan 26, 2020

Fixes #8717

It will be handled by the first of the following calls to `Dir.mkdir_p` within the `copy_files` method.
@jhass
Copy link
Member

jhass commented Jan 27, 2020

Well, we still want to do it for HTML output, no?

@Sija
Copy link
Contributor Author

Sija commented Jan 27, 2020

@jhass And it's being done - see my commit comment.

@jhass
Copy link
Member

jhass commented Jan 27, 2020

Ah good catch. Sorry, the mobile client didn't make it obvious there's one :)

@straight-shoota
Copy link
Member

I'd still keep this line and add is as first expression in generate_docs_html. That's preferable to an implicit creation which is purely based on order of instructions.

Copy link
Member

@RX14 RX14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, and the first call doesn't need to explicitly be anywhere. The copy_files mkdir_p calls are working exactly as intended.

@RX14 RX14 merged commit 433456f into crystal-lang:master Jan 27, 2020
@RX14 RX14 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:docs-generator labels Jan 27, 2020
@RX14 RX14 added this to the 0.33.0 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:tools:docs-generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

crystal docs -f json still makes docs folder
4 participants