Fix Enumerable#zip to work with union types #8621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
Sija
reviewed
Dec 25, 2019
src/enumerable.cr
Outdated
| # Try to see if we need to create iterators (or treat as iterators) | ||
| # for every element in `others`. | ||
| {% for type, type_index in U %} | ||
| {% if type < Indexable %} | ||
| if other{{type_index}}.is_a?(Indexable) |
There was a problem hiding this comment.
case would be imo tad moar cleaner here:
case other{{type_index}}
when Indexable
# ...
when Iterable
# ...
endditto below in .zip?
There was a problem hiding this comment.
Thanks, fixed. And also did it a bit differently...
RX14
approved these changes
Dec 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8608
Using runtime
is_a?instead of compile-time checks makes it work for union types.