Refactor String#to_utf16 optimizing for ascii-only #8526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you have any benchmarks for this? |
asterite
reviewed
Nov 27, 2019
|
Benchmark for 6a36aad string length 2000: string length 10: |
asterite
requested changes
Nov 27, 2019
src/string/utf16.cr
Outdated
| size = 0 | ||
| if ascii_only? | ||
| # size == bytesize, so each char fits in one UInt16 | ||
| return to_slice.map &.to_u16 |
There was a problem hiding this comment.
Oh, actually, this is missing the trailing null. I totally forgot about that! Sorry, maybe the other way was fine, or we just need to copy the values but add a trailing null somehow.
There was a problem hiding this comment.
Also, are there specs for these cases? They should have failed with this.
There was a problem hiding this comment.
Oh, right. There should be a spec for that.
Fryguy
reviewed
Nov 27, 2019
RX14
approved these changes
Dec 6, 2019
asterite
reviewed
Dec 6, 2019
asterite
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.