Parse newline before clsoing paren of pseudo method call #8320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed crystal-lang#8318 Note that this fix does not need to modify formatter because all pseudo methods are formatted as if these methods are usual call.
makenowjust
commented
Oct 13, 2019
| @@ -4914,6 +4914,9 @@ module Crystal | |||
| exps << parse_op_assign | |||
| if @token.type == :"," | |||
| next_token_skip_space_or_newline | |||
| else | |||
| skip_space_or_newline | |||
| check :")" | |||
There was a problem hiding this comment.
Maybe this fix seems funny. But these lines are derived from usual arguments parsing (here)
straight-shoota
approved these changes
Oct 13, 2019
asterite
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #8318
Note that this fix does not need to modify formatter because all pseudo methods are formatted as if these methods are usual
Call.