Compiler: fix missing name_location of some calls

[asterite]

Fixes #8191

I think these were all the missing cases, but I'm not sure.

We have two choices:

1. use location if name_location is missing: that way we'll never know if we missed setting a name_location somewhere
2. just use name_location and crash if it's missing: bad for users, though they can still compile their code with --no-debug, but we'll know we are missing something and we can fix it

Probably 2 is better, so I didn't change anything else.

In any case, this line is smelly:

crystal/src/compiler/crystal/codegen/primitives.cr

Line 17 in d1a8e77

@call_location = call.name_location if call && call.location

it's strange that we check call.location to determine copying call.name_location. Shouldn't we check for name_location?

(though this seems to work, probably because location is set in more places than name_location)

[bcardiff]

We can change the smelly line probably to name_location in both cases.

I would've used the same resource as in playground spec to highlight the expected name location with a special character. But that's me that I don't like to count cols and lines.

[bew]

What's the difference between location and name_location ?

[asterite]

@bew

foo.bar(1 + 2)
^   ^
|   |----- name_location
|
|--------- location

When an error says undefined method "bar" it will point and underline "bar" instead of somewhere at "foo". This is specially needed when "bar" appears in a different line:

foo.
  bar(1 + 2)

In the case of 1 + 2 I think the name_location will point to + instead of 1.