Deprecate redundant OptionParser#parse! #8041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
approved these changes
Aug 4, 2019
OptionParser#parse! deprecate.
didactic-drunk
force-pushed
the
optparse_order2
branch
from
e245557 to
adb2ce8
Compare
didactic-drunk
changed the title
jhass
approved these changes
Aug 5, 2019
RX14
approved these changes
Aug 11, 2019
dnamsons
pushed a commit
to dnamsons/crystal
that referenced
this pull request
Jan 10, 2020
OptionParser#parse! deprecate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially based on @chocolateboy's suggestion, @jhass's thumbs up in #7846 and review requests by @straight-shoota to prefer arguments over additional methods.