Formatter: consider consecutive macro literals when subformatting #8034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lexer might produce consecutive macro literals instead of just a single one, so when subformatting consider this case too.
asterite
added
kind:bug
Sija
reviewed
Aug 2, 2019
asterite
force-pushed
the
formatter-inline-multiple
branch
from
60beb69 to
94077cb
Compare
Sija
reviewed
Aug 3, 2019
waj
approved these changes
Aug 5, 2019
bcardiff
pushed a commit
that referenced
this pull request
Aug 8, 2019
) * Formatter: consider consecutive macro literals when subformatting The lexer might produce consecutive macro literals instead of just a single one, so when subformatting consider this case too. * Formatter: correctly subformat comments * Formatter: track def args when subformatting * Formatter: consider content after comment when subformatting * Formatter: consider nested macros when subformatting * Run formatter * fixup! Formatter: consider nested macros when subformatting
dnamsons
pushed a commit
to dnamsons/crystal
that referenced
this pull request
Jan 10, 2020
…ystal-lang#8034) * Formatter: consider consecutive macro literals when subformatting The lexer might produce consecutive macro literals instead of just a single one, so when subformatting consider this case too. * Formatter: correctly subformat comments * Formatter: track def args when subformatting * Formatter: consider content after comment when subformatting * Formatter: consider nested macros when subformatting * Run formatter * fixup! Formatter: consider nested macros when subformatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lexer might produce consecutive macro literals instead of just a single one, so when subformatting consider this case too.
Spotted by @waj