HTTP::Server: don't double-close response #7908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asterite
added
kind:bug
asterite
force-pushed
the
bug/http-server-leftover
branch
from
6bde0f1 to
cb7bccd
Compare
asterite
changed the title
|
This seems like a good candidate for a test. |
|
I cannot make a pr into your branch. But I added one spec. |
|
Does that spec pass if you remove my diff? |
|
@wontruefree The spec passes even without my check. It's really hard to test it. |
|
Maybe it is not worth writing a spec for. |
sdogruyol
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7832
Sorry this has no tests but it's really hard to test.