Implement named/pos_args annotation methods

[Blacksmoke16]

Resolves #7692.

Adds #named_args and #args methods to Annotation.

[Blacksmoke16]

Good for review again @bcardiff @straight-shoota

[bcardiff]

LGTM but it needs a rebase on master to make the CI happy

[bew]

Imo args should return something with pos + named args, that why i suggested pos_args in the first place to target only positional args. (the same comment goes for Call)

[Blacksmoke16]

@bcardiff @bew Would it be worth to add pos_args back in addition to the other two? Then you could either target all args, only named, or only positional?

If so It would be pretty easy to do and I could take care of that today.

[Blacksmoke16]

Thinking of this more, the challenge with returning them both would be how to do that, since they are of different "types". Could have #args return like Tuple(Tuple(Positional), NamedTuple(Named)) Or even a named tuple like NamedTuple(positional: Tuple(Positional), named: NamedTuple(Named)).

[Blacksmoke16]

@bcardiff @bew @straight-shoota Could you review this again? I added #args method that will return a named tuple representing both positional and named args.

{named: {foo: "bar"}, positional: {1, true, 17}}

So now it's possible to get positional arguments, named arguments, or both off of an annotation.

[RX14]

I'd prefer not to return a named tuple, no other macro methods behave like this. I'm a bit lost to the usecase of #args...

[Blacksmoke16]

@RX14 I'd also be fine with removing #args and just keeping #pos_args and #named_args.

[RX14]

@Blacksmoke16 that would be great. In fact, I'd just name #pos_args as #args. I'd like others feedback though.

[bcardiff]

Using only args (for positional args) and named_args to match the AST seems the best alternative to me.

[Blacksmoke16]

@RX14 @bcardiff Done.

[bcardiff]

Eventually, I would like to see a more structured API for annotations. I don't think this will be a definitive API for this. But is serves for now. So, to be used it with caution :-)

[Blacksmoke16]

Works for me. This is a big improvement over my current hack I'm using :P

[straight-shoota]

Thank you @Blacksmoke16