Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize String#to_u methods for the case of a negative number #7446

Merged
merged 6 commits into from
May 21, 2019
Merged

Optimize String#to_u methods for the case of a negative number #7446

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8970de0
Optimize String#to_u methods for the case of a negative number
Feb 17, 2019
1d92642
Make to_u64_info a macro to avoid runtime check
Feb 26, 2019
52e05e3
Fix to_u64_info
Feb 26, 2019
b015d26
Make to_u64_info a method again
Mar 1, 2019
fd766cc
Merge branch 'master' into patch-23
wooster0 Apr 18, 2019
da03352
Merge branch 'master' into patch-23
wooster0 May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into patch-23
  • Loading branch information
@wooster0
wooster0 authored Apr 18, 2019
commit fd766ccf6e7ccd92f6f8163c377c6cb2832abc47
2 changes: 1 addition & 1 deletion src/string.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ class String
end

value = 0_u64
mul_overflow = ~0_u64 / base
mul_overflow = ~0_u64 // base
last_is_underscore = true
invalid = false

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.