Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove quotes from overflow symbols in formatter spec #6968

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Remove quotes from overflow symbols in formatter spec #6968

merged 1 commit into from
Jan 2, 2019

Conversation

wooster0
Copy link
Contributor

No description provided.

@j8r
Copy link
Contributor

j8r commented Oct 20, 2018

It will be more explicit to rename the PR/commit like "Remove quotes assertion in the formatter spec"

@wooster0 wooster0 changed the title Do 0.26.0 TODO Remove quotes from overflow symbols in formatter spec Oct 20, 2018
@straight-shoota
Copy link
Member

For some reason this keeps repeatedly failing on circleci/test_linux because of either one of #6961 or #7243. I doubt it's related to this PR, but the statistical accumulation is at least suspicious.

@RX14 RX14 merged commit a27ad60 into crystal-lang:master Jan 2, 2019
@RX14 RX14 added this to the 0.27.1 milestone Jan 2, 2019
@RX14 RX14 added the kind:specs label Jan 2, 2019
@sdogruyol sdogruyol mentioned this pull request Jan 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:tools:formatter
Projects
None yet
Milestone
0.27.1
Development

Successfully merging this pull request may close these issues.
6 participants
@wooster0 @j8r @straight-shoota @asterite @bcardiff @RX14