Add support for specifying the build date #6788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why would you want to set a specific build date? |
|
To have a more deterministic build. On NixOS we generally set the date in the build environment to the start of the unix epoch. |
bcardiff
approved these changes
Sep 24, 2018
|
Should this be |
|
I have changed the variable name to @jhass's suggestion. I noticed that CircleCI fails on Darwin with this change. Is that expected? Also, do you require a test? |
bcardiff
approved these changes
Sep 24, 2018
There was a problem hiding this comment.
@peterhoeg thanks. There is no test required for this.
Darwin is failing for unrelated reasons (llvm7 support will fix that).
jhass
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the compiler gets the compilation date embedded into it - instead allow a date to be specified (would typically be the release date) so that subsequent compilations would not be different.
Further to #3973
Do you still require specs for something this small?
Tangibly, this will be used by NixOS/nixpkgs#47166 instead of the ugly replacement I'm doing over there.