Implement Random for BigInt #6687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Sep 8, 2018
RX14
approved these changes
Sep 8, 2018
asterite
requested changes
Sep 8, 2018
RX14
approved these changes
Sep 9, 2018
spec/std/random_spec.cr
Outdated
| x.should be >= 0 | ||
| x.should be < 2 | ||
|
|
||
| rand(0.to_big_i).should eq(0.to_big_i) |
There was a problem hiding this comment.
This contradicts with #6686
There was a problem hiding this comment.
Yep, whichever of those gets merged 2nd, will need to be changed
spec/std/random_spec.cr
Outdated
| @@ -115,6 +143,12 @@ describe "Random" do | |||
| expect_raises ArgumentError, "Invalid range for rand: 1..0" do | |||
| rand(1..0) | |||
| end | |||
| expect_raises ArgumentError, "Invalid range for rand: 1_big_i...1_big_i" do | |||
There was a problem hiding this comment.
1_big_i isn't a thing. Maybe better use 1.to_big_i as in code.
There was a problem hiding this comment.
Well I didn't make this up, it's just to_s. But a good idea to change that to also rely on to_s.
asterite
approved these changes
Sep 10, 2018
ysbaddaden
approved these changes
Sep 10, 2018
|
Yeah this is ready, as long as there are no merge conflicts |
RX14
approved these changes
Sep 10, 2018
ezrast
pushed a commit
to ezrast/crystal
that referenced
this pull request
Oct 2, 2018
* Implement Random for BigInt Fixes crystal-lang#5647 * spec typo fix * Move to big_int.cr * Use to_s in spec * Remove special case of zero because it will be removed in crystal-lang#6686
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5647
cc @iSarCasm @jzakiya