Compiler: make sure to remove literal types before instantiating matches #6284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RX14
approved these changes
Jun 28, 2018
|
|
sdogruyol
approved these changes
Jun 28, 2018
RX14
added
kind:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6239
When initial lookup matches fail, we do a second lookup with "literal types", for the automatic cast. If there are matches, those literal types must be converted back to the real types (because those literal types are just used for the lookup, they are fictitious). This was done in a few places, but apparently not in all of them.
This PR changes the code to make sure that, before instantiating those matches, if the lookup was done with those literal types, they are removed.