Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link in openssl.cr #5946

Merged
merged 2 commits into from
May 3, 2018
Merged

Fix link in openssl.cr #5946

merged 2 commits into from
May 3, 2018

Conversation

wooster0
Copy link
Contributor

ysbaddaden
ysbaddaden requested changes Apr 14, 2018
View reviewed changes
Copy link
Contributor

@ysbaddaden ysbaddaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but here is a terrible naming, and we should still link to the official OpenSSL website or a RFC. If it's not available anymore, let's drop the link.

@wooster0
Copy link
Contributor Author

wooster0 commented Apr 14, 2018 •
edited
Loading

@ysbaddaden I also found https://www.openssl.org/docs/manmaster/man1/ciphers.html. But https://www.openssl.org/docs/manmaster/man1/ciphers.html#CIPHER_STRINGS doesn't works on this page. It still starts from the top.

Hmm.. What about http://openssl.cs.utah.edu/docs/apps/ciphers.html#cipher_strings ?

@RX14
Copy link
Member

RX14 commented Apr 14, 2018 •
edited
Loading

https://www.openssl.org/docs/man1.1.0/apps/ciphers.html#CIPHER-STRINGS

URL fragments are based on the id of the page element, they can be gotten from looking at the page source.

@wooster0
Copy link
Contributor Author

aah okay! That makes sense

@wooster0
Copy link
Contributor Author

wooster0 commented Apr 30, 2018 •
edited
Loading

@ysbaddaden I changed the naming and it links to the official OpenSSL website now. Is still something wrong?

@ysbaddaden ysbaddaden merged commit 5e518f9 into crystal-lang:master May 3, 2018
@ysbaddaden
Copy link
Contributor

Thanks!

@RX14 RX14 added this to the Next milestone May 3, 2018
chris-huxtable pushed a commit to chris-huxtable/crystal that referenced this pull request Jun 6, 2018
@wooster0 @chris-huxtable
Fix link to full ciphers list in openssl.cr (crystal-lang#5946)
5d9f599
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ysbaddaden ysbaddaden ysbaddaden approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:docs topic:stdlib
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wooster0 @RX14 @ysbaddaden @straight-shoota