Skip to content

Refactor flag and value parsing into a separate method #16300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2025
Merged

Refactor flag and value parsing into a separate method #16300

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 6 additions & 19 deletions src/option_parser.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,27 +447,14 @@ class OptionParser
# Parses a command-line argument into a flag and optional inline value.
private def parse_arg_to_flag_and_value(arg : String) : {String, String?}
if arg.starts_with?("--")
value_index = arg.index('=')
if value_index
flag = arg[0...value_index]
value = arg[value_index + 1..-1]
else
flag = arg
value = nil
name, separator, value = arg.partition("=")
if separator == "="
return {name, value}
end
elsif arg.starts_with?('-')
if arg.size > 2
flag = arg[0..1]
value = arg[2..-1]
else
flag = arg
value = nil
end
else
flag = arg
value = nil
elsif arg.starts_with?('-') && arg.size > 2
return {arg[0..1], arg[2..]}
end
{flag, value}
{arg, nil}
end

# Processes a single flag/subcommand. Matches original behaviour exactly.
Expand Down